add Thread/get support & References to previous method results

[qyb]

No description provided.

[alagane]

Hello, isn't the method thread_get part missing from the index.ts file?

[qyb]

Hello, isn't the method thread_get part missing from the index.ts file?

I'm trying to add thread test with james:memory. I want to implement one request combining 4 methods (Email/query + Email/get + Thread/get + Email/get) as the description in https://jmap.io/client.html#cold-boot

But I cannot get thread work. I forged some .eml files with related Message-ID/In-Reply-To/References header. Then I use james-cli ImportEml command to import them. But the system didn't recognize threads. May you give me some tips?

[chibenwa]

But I cannot get thread work. I forged some .eml files with related Message-ID/In-Reply-To/References header. Then I use james-cli ImportEml command to import them. But the system didn't recognize threads. May you give me some tips?

@quantranhong1999 ?

[chibenwa]

@qyb can you share the EML in question? (attached ZIP)

[qyb]

But I cannot get thread work. I forged some .eml files with related Message-ID/In-Reply-To/References header. Then I use james-cli ImportEml command to import them. But the system didn't recognize threads. May you give me some tips?

@quantranhong1999 ?

I have done my research about memory-app ThreadIdGuessingAlgorithm implementation. Maybe it was just a naiveAlgorighm?

Anyway, it won't stop the test's logical.:)

[quantranhong1999]

I have done my research about memory-app ThreadIdGuessingAlgorithm implementation. Maybe it was just a naiveAlgorighm?

We are using SearchThreadIdGuessingAlgorithm (search on memory) implementation for memory-app.

I want to implement one request combining 4 methods (Email/query + Email/get + Thread/get + Email/get) as the description in https://jmap.io/client.html#cold-boot. But I cannot get thread work.

As far as I know, James does not support collapseThreads option for Email/query yet so it would not work like the example for now. For short the thread paging is not support by James by now.

[qyb]

I have done my research about memory-app ThreadIdGuessingAlgorithm implementation. Maybe it was just a naiveAlgorighm?

We are using SearchThreadIdGuessingAlgorithm (search on memory) implementation for memory-app.

docker exec e26fd3fdb97c james-cli AddUser user1@localhost password

provisioning mailbox (by fetchSession/login...)

docker exec e26fd3fdb97c james-cli ListUserMailboxes user1@localhost
docker exec e26fd3fdb97c james-cli ImportEml "#private" user1@localhost INBOX /root/conf/1.eml
docker exec e26fd3fdb97c james-cli ImportEml "#private" user1@localhost Sent /root/conf/2.eml
docker exec e26fd3fdb97c james-cli ImportEml "#private" user1@localhost INBOX /root/conf/3.eml

I expect INBOX should be only 1 thread. but mailbox_get shows two threads in INBOX
eml.zip
.

[quantranhong1999]

What is the James memory version you are using? BTW can you try Email/query and then Email/get threadId properties to see the mapping between messageId and threadId first?

[qyb]

As far as I know, James does not support collapseThreads option for Email/query yet so it would not work like the example for now. For short the thread paging is not support by James by now.

Yes, you're right. I imported three EML files by JMAP Email/import method. They were recognized as one threadId successfully. But collapseThreads result is still multiple threads.

Anyway. I'll add Email/import and Thread/get method in the following commits

[quantranhong1999]

Good to hear that :')

[chibenwa]

But collapseThreads result is still multiple threads.

We (in James) did not implement it just yet (as it would require to push aggregation down to the search engine)

Contributions welcomed for the willing ;-)

[qyb]

But collapseThreads result is still multiple threads.

We (in James) did not implement it just yet (as it would require to push aggregation down to the search engine)

Contributions welcomed for the willing ;-)

Now, this pull request just remains ResultReference test. :)

[alagane]

How is the keystore generated?
I used a keypair on my pull request #62
I don't know which method is better, but I personally prefair to not have binary files is possible.
I think the best method would be to generate the keypair/keystore when running tests if none is found on the directory, and ignore it on .gitignore

[qyb]

How is the keystore generated? I used a keypair on my pull request #62 I don't know which method is better, but I personally prefair to not have binary files is possible. I think the best method would be to generate the keypair/keystore when running tests if none is found on the directory, and ignore it on .gitignore

https://www.npmjs.com/package/keypair is our need.

I'll remove ResultReference object from this pr because now I think it should be in another pull request. This PR is too complex and putting multiple arguments in one request is another complex thing.

[alagane]

Ready to merge for me.
Thank you for your contribution!

[chibenwa]

This looks great to me!