TF-4308 [Part 2] Add create a label button for Choose Label modal#4332
Open
dab246 wants to merge 3 commits intofeatures/tf-4308-add-labels-for-several-messagesfrom
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/4332. |
dab246
force-pushed
the
features/tf-4308-add-labels-for-several-messages
branch
from
a70e1ad to
08d2a8c
Compare
dab246
force-pushed
the
features/tf-4308-add-create-label-for-choose-label-modal
branch
from
0dbfd85 to
16eba67
Compare
Comment on lines
+161
to
+170
| Widget _buildCloseButton() { | ||
| return Positioned( | ||
| top: 0, | ||
| right: 0, | ||
| child: DefaultCloseButtonWidget( | ||
| iconClose: widget.imagePaths.icCloseDialog, | ||
| isAlignTopEnd: false, | ||
| onTapActionCallback: _onCloseModal, | ||
| ), | ||
| ); |
Collaborator
There was a problem hiding this comment.
DefaultCloseButtonWidget itself returns a PositionedDirectional. Nested positioned widgets is causing this exception when opening choose label modal:
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following assertion was thrown while looking for parent data.:
Incorrect use of ParentDataWidget.
Competing ParentDataWidgets are providing parent data to the same RenderObject:
- Positioned(left: 4.0, top: 4.0), which writes ParentData of type StackParentData, (typically
placed directly inside a Stack widget)
- Positioned(top: 0.0, right: 0.0), which writes ParentData of type StackParentData, (typically
placed directly inside a Stack widget)
A RenderObject can receive parent data from multiple ParentDataWidgets, but the Type of ParentData
must be unique to prevent one overwriting another.
Usually, this indicates that one or more of the offending ParentDataWidgets listed above isn't
placed inside a dedicated compatible ancestor widget that it isn't sharing with another
ParentDataWidget of the same type.
Otherwise, separating aspects of ParentData to prevent conflicts can be done using mixins, mixing
them all in on the full ParentData Object, such as KeepAlive does with KeepAliveParentDataMixin.
The ownership chain for the RenderObject that received the parent data was:
ClipPath ← Material ← TMailContainerWidget ← TMailButtonWidget ← Positioned ←
PositionedDirectional ← DefaultCloseButtonWidget ← Positioned ← Stack ← Padding ← ⋯
When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 266:3 throw_
errors.dart:266
package:flutter/src/widgets/framework.dart 6575:11 <fn>
framework.dart:6575
package:flutter/src/widgets/framework.dart 6619:14 [_debugCheckCompetingAncestors]
framework.dart:6619
package:flutter/src/widgets/framework.dart 6667:7 <fn>
framework.dart:6667
package:flutter/src/widgets/framework.dart 6673:14 [_findAncestorParentDataElements]
framework.dart:6673
package:flutter/src/widgets/framework.dart 6836:9 attachRenderObject
framework.dart:6836
package:flutter/src/widgets/framework.dart 6696:5 mount
framework.dart:6696
package:flutter/src/widgets/framework.dart 7007:11 mount
framework.dart:7007
... Normal element mounting (45 frames)
package:flutter/src/widgets/framework.dart 4539:15 inflateWidget
framework.dart:4539
package:flutter/src/widgets/framework.dart 7159:36 inflateWidget
framework.dart:7159
package:flutter/src/widgets/framework.dart 7175:32 mount
framework.dart:7175
... Normal element mounting (22 frames)
package:flutter/src/widgets/framework.dart 4539:15 inflateWidget
framework.dart:4539
package:flutter/src/widgets/framework.dart 4004:18 updateChild
framework.dart:4004
package:flutter/src/widgets/layout_builder.dart 249:18 updateChildCallback
layout_builder.dart:249
package:flutter/src/widgets/framework.dart 3046:11 buildScope
framework.dart:3046
package:flutter/src/widgets/layout_builder.dart 272:5 [_rebuildWithConstraints]
layout_builder.dart:272
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 117:77 tear
operations.dart:117
package:flutter/src/widgets/layout_builder.dart 335:28 layoutCallback
layout_builder.dart:335
package:flutter/src/rendering/object.dart 4160:33 <fn>
object.dart:4160
package:flutter/src/rendering/object.dart 2885:9 <fn>
object.dart:2885
package:flutter/src/rendering/object.dart 1209:7 [_enableMutationsToDirtySubtrees]
object.dart:1209
package:flutter/src/rendering/object.dart 2884:7 invokeLayoutCallback
object.dart:2884
package:flutter/src/rendering/object.dart 4160:5 runLayoutCallback
object.dart:4160
package:flutter/src/widgets/layout_builder.dart 449:5 performLayout
layout_builder.dart:449
package:flutter/src/rendering/object.dart 2766:7 layout
object.dart:2766
package:flutter/src/rendering/proxy_box.dart 115:10 <fn>
proxy_box.dart:115
package:flutter/src/rendering/object.dart 2766:7 layout
object.dart:2766
package:flutter/src/rendering/proxy_box.dart 115:10 <fn>
proxy_box.dart:115
package:flutter/src/rendering/object.dart 2766:7 layout
object.dart:2766
package:flutter/src/rendering/proxy_box.dart 115:10 <fn>
proxy_box.dart:115
package:flutter/src/rendering/object.dart 2766:7 layout
object.dart:2766
package:flutter/src/rendering/proxy_box.dart 115:10 <fn>
proxy_box.dart:115
package:flutter/src/rendering/object.dart 2766:7 layout
object.dart:2766
package:flutter/src/rendering/proxy_box.dart 115:10 <fn>
proxy_box.dart:115
package:flutter/src/rendering/object.dart 2766:7 layout
object.dart:2766
package:flutter/src/rendering/proxy_box.dart 115:10 <fn>
proxy_box.dart:115
package:flutter/src/rendering/object.dart 2766:7 layout
object.dart:2766
package:flutter/src/rendering/proxy_box.dart 115:10 <fn>
proxy_box.dart:115
package:flutter/src/rendering/proxy_box.dart 3857:13 performLayout
proxy_box.dart:3857
package:flutter/src/rendering/object.dart 2766:7 layout
object.dart:2766
package:flutter/src/rendering/proxy_box.dart 115:10 <fn>
proxy_box.dart:115
package:flutter/src/rendering/object.dart 2766:7 layout
object.dart:2766
package:flutter/src/widgets/overlay.dart 1085:12 layoutChild
overlay.dart:1085
package:flutter/src/widgets/overlay.dart 1431:9 performLayout
overlay.dart:1431
package:flutter/src/rendering/object.dart 2614:7 [_layoutWithoutResize]
object.dart:2614
package:flutter/src/rendering/object.dart 1160:17 flushLayout
object.dart:1160
package:flutter/src/rendering/object.dart 1173:14 flushLayout
object.dart:1173
package:flutter/src/rendering/binding.dart 629:5 drawFrame
binding.dart:629
package:flutter/src/widgets/binding.dart 1242:13 drawFrame
binding.dart:1242
package:flutter/src/rendering/binding.dart 495:5 [_handlePersistentFrameCallback]
binding.dart:495
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 117:77 tear
operations.dart:117
package:flutter/src/scheduler/binding.dart 1438:7 [_invokeFrameCallback]
binding.dart:1438
package:flutter/src/scheduler/binding.dart 1351:9 handleDrawFrame
binding.dart:1351
package:flutter/src/scheduler/binding.dart 1204:5 [_handleDrawFrame]
binding.dart:1204
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 117:77 tear
operations.dart:117
lib/_engine/engine/platform_dispatcher.dart 1312:5 invoke
platform_dispatcher.dart:1312
lib/_engine/engine/platform_dispatcher.dart 255:5 invokeOnDrawFrame
platform_dispatcher.dart:255
lib/_engine/engine/frame_service.dart 189:32 [_renderFrame]
frame_service.dart:189
lib/_engine/engine/frame_service.dart 101:9 <fn>
frame_service.dart:101
dart-sdk/lib/async/zone.dart 1546:13 _rootRunUnary
zone.dart:1546
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 117:77 tear
operations.dart:117
dart-sdk/lib/async/zone.dart 1429:19 runUnary
zone.dart:1429
dart-sdk/lib/async/zone.dart 1350:26 <fn>
zone.dart:1350
dart-sdk/lib/_internal/js_dev_runtime/patch/js_allow_interop_patch.dart 224:27 _callDartFunctionFast1
js_allow_interop_patch.dart:224
════════════════════════════════════════════════════════════════════════════════════════════════════
Member
Author
It's still working fine, please double-check. Screen.Recording.2026-03-31.at.12.30.28.mov |
tddang-linagora
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#4308
Resolved
Screen.Recording.2026-02-12.at.14.26.46.mov