Convert CubicBez::nearest to the poly-cool quintic solver#493
Merged
jneem merged 1 commit intolinebender:mainfrom Nov 27, 2025
Merged
Convert CubicBez::nearest to the poly-cool quintic solver#493jneem merged 1 commit intolinebender:mainfrom
CubicBez::nearest to the poly-cool quintic solver#493jneem merged 1 commit intolinebender:mainfrom
Conversation
|
Once poly-cool is used by Kurbo, I would recommend making a quick PR to finish up the tangent/normal to point family of functions, which would supersede #417 and add support for normals as well. Since that is low-hanging fruit to fill in some of Bezier-rs's extra functionality back in Kurbo where it seems noticeably missing. |
Member
Author
|
Ok, I've updated this to use the newly-in-repo polycool. |
nicoburns
approved these changes
Nov 27, 2025
nicoburns
left a comment
There was a problem hiding this comment.
I have no real insight into the math here. But this has been discussed several times and the consensus always seems to have been in favour of merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
CubicBez::nearestuses subdivision toQuadBezand then a cubic solver. This converts it to the quintic solver inpoly-coolfor a nice speedup (3000x for high accuracy!) and better robustness.Fixes #446
Maybe it would make sense to propose moving poly-cool to linebender first? I wasn't sure...
This bumps MSRV from 1.82 to 1.85, which has more
f64methods incoreand also supports edition 2024.