Get as close as possible to full no_std support#160
Merged
mwcampbell merged 2 commits intomainfrom Nov 7, 2024
Merged
Conversation
xorgy
approved these changes
Nov 6, 2024
Contributor
Author
|
I saw @xorgy's approval. The only reason I'm not merging this immediately is that I wonder if we should land dfrg/swash#63 first, and publish a new version of swash (presumably a semver-breaking release), so we can go all the way with this PR. If people think it would be better to merge this PR immediately, that's fine. |
Contributor
|
dfrg/swash#63 and dfrg/swash#61 have both landed now. I have submitted a couple of additional PRs for swash and I don't know what his plans are for doing a new release. |
Member
|
I think it's fine to land this and when Merged PRs are better than lingering PRs. When work can be split, it should. Helps reduce merge conflicts for yourself and others. Keeps the ball rolling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To really get no-std support in parley, we need to land dfrg/swash#63. But I believe I've done everything else that's necessary, in both parley and fontique. One can test the build by patching Cargo.toml to use the working branch for that swash PR, and modifying parley/Cargo.toml to specify swash/std or swash/libm as appropriate. If we decide to land dfrg/swash#63 before landing this one, then I can make the latter modification to parley/Cargo.toml before merging this PR.
Some of my changes, e.g. unconditionally using
alloc::vec::Vec, are designed to minimize the amount of noise when searching the whole source tree for "std".