Add cursor tests for RTL text followed by newline#305
Draft
valadaptive wants to merge 1 commit intolinebender:mainfrom
Draft
Add cursor tests for RTL text followed by newline#305valadaptive wants to merge 1 commit intolinebender:mainfrom
valadaptive wants to merge 1 commit intolinebender:mainfrom
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #298.
It turns out to be a bit worse than I originally thought--when I used ctrl+left arrow in the vello_editor example, it just put me back at the start of the word. But when I call
previous_visual_wordhere, it actually hangs and loops infinitely!I'm not confident that the assertions for the expected behavior are correct--the assertion helpers seem to be a bit weird. As such, anyone fixing this should not necessarily expect the tests to pass once they've done so.