Use the correct family ID when adding font aliases#380
Merged
valadaptive merged 2 commits intolinebender:mainfrom Jun 13, 2025
Merged
Use the correct family ID when adding font aliases#380valadaptive merged 2 commits intolinebender:mainfrom
valadaptive merged 2 commits intolinebender:mainfrom
Conversation
valadaptive
commented
Jun 13, 2025
dfrg
approved these changes
Jun 13, 2025
Collaborator
dfrg
left a comment
dfrg
left a comment
There was a problem hiding this comment.
LGTM. This was certainly the intended behavior so it seems fine to land the change and address any potential issues with other backends if they arise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered this as part of #378; splitting it off because it affects all the fontique backends.
When adding font aliases, the code was not actually using the family ID we passed in, but creating a fresh family ID each time. This meant that font aliases were all mapped to nonexistent family IDs, and all queries for a font by one of its aliases would fail.
I'm a bit concerned that this has the potential to cause regressions or other general weirdness, since all font aliases went unused due to this bug. Not sure how to test that other than to just give it a spin.