attributed_text: add IntoIterator support for ActiveSpans#556
Merged
waywardmonkeys merged 1 commit intolinebender:mainfrom Feb 18, 2026
Merged
Conversation
waywardmonkeys
force-pushed
the
active-spans-into-iterator
branch
from
37c9872 to
f61adff
Compare
tomcur
approved these changes
Feb 18, 2026
Member
tomcur
left a comment
tomcur
left a comment
There was a problem hiding this comment.
Could consider dropping the implementations of ActiveSpansIter / ActiveSpansIterRev, and write something like self.active_ids.iter().map(|id| self.attributed.attribute_at_idx(id as usize).expect("...")). That could still return a nameable type if desired, wrapping the Map<...> (e.g. ActiveSpansIterRev::ids already wraps Rev<Iter<...>> itself); but could also just return impl ExactSizeIterator.
Implement `IntoIterator` for `&ActiveSpans` so callers can iterate with for loops without extra allocation. Expose `ActiveSpansIter` and `ActiveSpansIterRev`, update docs with an `&active_spans` loop example, and add a unit test for reference iteration semantics.
waywardmonkeys
force-pushed
the
active-spans-into-iterator
branch
from
f61adff to
83d3f9b
Compare
Contributor
Author
|
Opting out of the last request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
IntoIteratorfor&ActiveSpansso callers can iterate with for loops without extra allocation.Expose
ActiveSpansIterandActiveSpansIterRev, update docs with an&active_spansloop example, and add a unit test for reference iteration semantics.