attributed_text: make AttributeSegments report exact length#557
Merged
waywardmonkeys merged 1 commit intolinebender:mainfrom Feb 18, 2026
Merged
Conversation
Implement exact iterator cardinality for `AttributeSegments` by adding: - `Iterator::size_hint` with exact lower/upper bounds - `ExactSizeIterator` with `len()` `AttributeSegments` iterates over remaining adjacent boundary pairs, so remaining item count is exactly `boundaries.len() - 1 - index`. Also adds a regression test that validates `size_hint` as iteration advances.
waywardmonkeys
force-pushed
the
attribute-segments-size-hint
branch
from
f503cae to
6946808
Compare
xorgy
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement exact iterator cardinality for
AttributeSegmentsby adding:Iterator::size_hintwith exact lower/upper boundsExactSizeIteratorwithlen()AttributeSegmentsiterates over remaining adjacent boundary pairs, so remaining item count is exactlyboundaries.len() - 1 - index.Also adds a regression test that validates
size_hintas iteration advances.