Skip to content

attributed_text: clarify attribute query scan complexity docs #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waywardmonkeys merged 1 commit into from
Feb 18, 2026
Merged

attributed_text: clarify attribute query scan complexity docs #558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions attributed_text/src/attributed_text.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ impl<T: Debug + TextStorage, Attr: Debug> AttributedText<T, Attr> {
///
/// Attributes are yielded in the order they were applied. This doesn't handle conflicting
/// attributes, it just reports everything.
///
/// This performs a full scan of all attributes on each call (`O(n)` in applied span count).
pub fn attributes_at(&self, index: usize) -> impl Iterator<Item = (&Range<usize>, &Attr)> {
self.attributes.iter().filter_map(move |(attr_span, attr)| {
if attr_span.contains(&index) {
Expand All @@ -103,6 +105,13 @@ impl<T: Debug + TextStorage, Attr: Debug> AttributedText<T, Attr> {
///
/// Attributes are yielded in the order they were applied. This doesn't handle conflicting
/// attributes, it just reports everything.
///
/// This performs a full scan of all attributes on each call (`O(n)` in applied span count).
///
/// Use this for one-off overlap queries. For many queries over the same text, prefer
/// segment-based iteration with [`AttributeSegmentsWorkspace`](crate::AttributeSegmentsWorkspace):
/// segment once, then intersect your query ranges with yielded segments (which also provides
/// the exact covered subranges).
pub fn attributes_for_range(
&self,
range: Range<usize>,
Expand Down