Move ImageAlphaType into being ImageFormats instead#125
Open
DJMcNab wants to merge 1 commit intolinebender:mainfrom
Open
Move ImageAlphaType into being ImageFormats instead#125DJMcNab wants to merge 1 commit intolinebender:mainfrom
ImageAlphaType into being ImageFormats instead#125DJMcNab wants to merge 1 commit intolinebender:mainfrom
Conversation
Contributor
|
It may make sense to make |
Member
Author
I think the ergonomics of that are pretty poor (you lose exhaustive matching), but I can see the appeal. Fwiw, as it stands, the least significant bit is effectively the "is_premul" bit. |
Contributor
|
Alternative approach: enum ImageFormat {
Rgba8(AlphaType),
Bgra8(AlphaType),
}pros:
cons:
And TBH I think the ergonomics of nested type (easiness of use) is bothering me, so I am not really sure that this alternative approach is anyway better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not planning to merge this even with an approval, without some more discussion.
Just exploring what this would look like practically.
See the discussion in #121 (review).