Merged
Conversation
raphlinus
reviewed
Nov 23, 2022
piet/Cargo.toml
Outdated
| os_info = { version = "3.0.0", optional = true, default-features = false } | ||
| unic-bidi = "0.9" | ||
| image = { version = "0.24.2", optional = true, default-features = false } | ||
| kurbo = "0.8.3" |
Contributor
There was a problem hiding this comment.
Do we want to pull off the bandaid and jump to 0.9 now that's been released? I don't think there are any client changes that will be impacted, and I confirm the example compiles and runs without modification.
Member
Author
There was a problem hiding this comment.
May as well give it a try. I guess it has the downside of requiring a recent rustc but I don't think we've ever cared about supporting old compilers, right?
Member
There was a problem hiding this comment.
I think we're happy to be aggressive about msrv.
This way it will use the same toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase of #518, bumping all the versions to 0.6.0.