Merged
Conversation
jsturtevant
force-pushed
the
unic-to-icuprop
branch
3 times, most recently
from
1fdfcfc to
4e9a98e
Compare
Contributor
Author
|
I don't see any difference in the Windows snapshots but it does look like the Windows versioned changed. Not sure if that would make a difference? It's a pretty small percentage change |
Contributor
Author
|
@xStrom would this be something you would be interested in taking? |
Member
|
Sorry for the late response. Yes, this seems like a reasonable update. The CI error was unrelated to the changes in this PR and has now been resolved in |
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
force-pushed
the
unic-to-icuprop
branch
from
4e9a98e to
a1ef6dd
Compare
Contributor
Author
|
no problem! Thanks for taking a look. Things are passing after the rebase 💯 |
xStrom
approved these changes
Mar 3, 2026
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Thank you for this contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #599