Conversation
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
DJMcNab
left a comment
There was a problem hiding this comment.
I guess we can land this? Does it have any value for us?
Yes, it will fix #1066. |
|
I'd like some clarification on that then - this PR has not been marked as fixing that issue; is that because you want to leave it open to track adding a regression test (i.e. #1067)? I don't want to leave that as an orphan issue, and it's a nicer UX if the close event is correctly linked to the PR which addresses the issue. |
Yeah, I was planning to close in it with regression test, but I agree it's better to close it here. Do land if you think it's okay now. |
Depends on linebender/kurbo#467
Fixes #1066.