Port some tests to the new version of Vello Api#1369
Port some tests to the new version of Vello Api#1369DJMcNab wants to merge 7 commits intolinebender:mainfrom
Conversation
|
Some thoughts:
|
It's possible. I still do lean slightly towards duplicating them. The reasoning for this approach was to provide a testbed for the new Vello API work, rather than for actual test use. That is, I didn't think these tests don't need to be maintainable as such, because they'll eventually need to be blasted away and re-synced when we port the rest of the tests. With that said, I don't strongly have a position one way or the other. I certainly wouldn't block a follow-up PR to delete the duplicated tests. This feels like something to potentially discuss in office hours.
This PR seems an odd place for this concern; I do agree that running many of the same tests in Vello Classic would be nice, but it's a tradeoff around potentially making Vello API less fit-for-purpose (e.g. we're not likely to ever support "global" layers in Vello Classic, but the current Vello API does support them). |
This uses the version of Vello API which landed in #1360.
This code was mostly adapted from #1299, but changed to reflect the lack of
Renderertrait.These tests are duplicates of some existing tests, rather than new tests; indeed, they use the existing reference image for these tests. This is because we expect Vello API's API to still change substantially (especially around how brushes are handled), so keeping that localised/in a low merge-conflict way is the goal.