sparse_strips: Move filter handling logic from vello_cpu to vello_common#1446
Open
laurenz-canva wants to merge 8 commits intomainfrom
Open
sparse_strips: Move filter handling logic from vello_cpu to vello_common#1446laurenz-canva wants to merge 8 commits intomainfrom
laurenz-canva wants to merge 8 commits intomainfrom
Conversation
laurenz-canva
commented
Feb 16, 2026
|
|
||
| /// A filter that has been instantiated for a specific affine transformation. | ||
| #[derive(Debug)] | ||
| pub enum InstantiatedFilter { |
Contributor
Author
There was a problem hiding this comment.
Perhaps PreparedFilter would be a better name?
laurenz-canva
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this is a relatively isolated change, I decided to open a PR for this now so that it reduces the diff of follow-up PRs. All this PR does is simply:
InstantiatedFilterabstraction that allows instantiating a filter for a specific transform, since we need the same in vello_hybrid.There's a bit of a question whether we can deduplicate some of the predefined SVG filters and their instantiated versions, but for now this is the least invasive change, I think.