vello_hybrid: Unify texture creation code in WebGL backend#1448
Open
laurenz-canva wants to merge 3 commits intomainfrom
Open
vello_hybrid: Unify texture creation code in WebGL backend#1448laurenz-canva wants to merge 3 commits intomainfrom
laurenz-canva wants to merge 3 commits intomainfrom
Conversation
laurenz-canva
commented
Feb 16, 2026
Comment on lines
1501
to
1503
| gl.tex_parameteri( | ||
| WebGl2RenderingContext::TEXTURE_2D, | ||
| WebGl2RenderingContext::TEXTURE_MAX_LEVEL, |
Contributor
Author
There was a problem hiding this comment.
Would this still be needed?
laurenz-canva
force-pushed
the
laurenz/webgl-texture
branch
from
6cb3042 to
1c6108c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perhaps I am missing something obvious here, but I'm not sure I get why we were using different clamp/filtering modes for some textures? 🤔 If I'm not mistaken, we are only ever using direct texture loading, so it seems to me like it should be fine to always use the same mode? At least all WebGL tests still seem to pass, but please let me know if I'm wrong.
Other than that, this PR just puts all of that logic into a method to reduce code duplication. 🙂