vello_hybrid: Optimize rendering of opaque full-tile images#1461
Open
vello_hybrid: Optimize rendering of opaque full-tile images#1461
Conversation
LaurenzV
approved these changes
Feb 20, 2026
Collaborator
There was a problem hiding this comment.
Maybe we rename this to Custom instead of OpaqueId? Maybe it should also be a typed struct?
Collaborator
There was a problem hiding this comment.
(second one is up to you though, but the first one would be nice I think)
| /// Pixmap pixels were registered earlier; this is just a handle. | ||
| OpaqueId(ImageId), | ||
| /// | ||
| /// The `bool` indicates whether the image may contain non-opaque pixels. |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// The `bool` indicates whether the image may contain non-opaque pixels. | |
| /// The `bool` indicates whether the image may contain non-opaque pixels. If unsure, set this to `true`. |
Comment on lines
+77
to
+78
| let [a, b, c, d, e, f] = root_transform.as_coeffs(); | ||
| let snapped_root = Affine::new([a, b, c, d, e.round(), f.round()]); |
Collaborator
There was a problem hiding this comment.
Can be replaced with transform.with_translation()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip prior draw commands when a wide tile is fully covered by an opaque fill (opaque image). This avoids unnecessary compositing work for tiles that would be entirely overwritten.
I also added additional examples that allocate more and more images when pressing “a”, so I could run a very rough benchmark. It shows roughly a 1.65x improvement in the image randomized positioning scenario.
I am not entirely happy with the approach of carrying
may_have_opacitiesinsideImageSource, but I have not come up with a better solution yet. I would really welcome any ideas if you have suggestions.before.mp4
after.mp4