Add concept of "attached layers" to Masonry#1663
Open
PoignardAzur wants to merge 1 commit intolinebender:mainfrom
Open
Add concept of "attached layers" to Masonry#1663PoignardAzur wants to merge 1 commit intolinebender:mainfrom
PoignardAzur wants to merge 1 commit intolinebender:mainfrom
Conversation
xStrom
approved these changes
Feb 20, 2026
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Will need to see it in actual use to have a more informed opinion. However, what's here now looks ok.
| /// Creates a new [layer] at a specified `position`, and ties it to the current widget. | ||
| /// | ||
| /// The layer will be removed when the current widget is removed from the tree. | ||
| /// A widget can only have one layer of any given type `W` at a time: if a widget creates two layers of the same type, the old layer will be removed. |
Member
There was a problem hiding this comment.
Let's keep line lengths under 100.
Suggested change
| /// A widget can only have one layer of any given type `W` at a time: if a widget creates two layers of the same type, the old layer will be removed. | |
| /// A widget can only have one layer of any given type `W` at a time: | |
| /// if a widget creates two layers of the same type, the old layer will be removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.