Skip to content

Comments

Remove ViewArgument#1666

Merged
flosse merged 12 commits intolinebender:mainfrom
slowtec:remove-view-argument
Feb 18, 2026
Merged

Remove ViewArgument#1666
flosse merged 12 commits intolinebender:mainfrom
slowtec:remove-view-argument

Conversation

@flosse
Copy link
Contributor

@flosse flosse commented Feb 17, 2026

Motivated by #1638 (comment) this PR basically reverts #1444.

@flosse
Copy link
Contributor Author

flosse commented Feb 17, 2026

@PoignardAzur and @Philipp-M as announced, here is a PR that removes the ViewArgument trait.
@DJMcNab You had good reasons for introducing the trait, so there are certainly reasons to keep it.
I don't want to destroy your work, but if you're okay with reversing this step, it would be a bit of a relief in a few places (at least until rust-lang/rust#107374 is stabilized).

@flosse flosse marked this pull request as ready for review February 17, 2026 21:33
Copy link
Contributor

@PoignardAzur PoignardAzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate that you took the time to do that refactor!

We haven't had a big discussion about whether we want to remove ViewArgument, but as your PR shows, we're not using it anyway, and Xilem doesn't really have any maintainers right now, so I'll make a judgment call and say we can merge this without delay.

@PoignardAzur PoignardAzur added this pull request to the merge queue Feb 18, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2026
@flosse
Copy link
Contributor Author

flosse commented Feb 18, 2026

There were changes on the main branch in between... I'll fix that in a minute.

@flosse flosse enabled auto-merge February 18, 2026 17:21
@flosse flosse added this pull request to the merge queue Feb 18, 2026
Merged via the queue into linebender:main with commit 781138a Feb 18, 2026
17 checks passed
@flosse flosse deleted the remove-view-argument branch February 18, 2026 18:16
@RagibHasin
Copy link
Contributor

I'm a little too late to the party it seems. I have just been using this feature to ease on unwrapping in handlers.

I guess it is refactor time for me. 😢

@flosse
Copy link
Contributor Author

flosse commented Feb 19, 2026

I'm a little too late to the party it seems. I have just been using this feature to ease on unwrapping in handlers.

What exactly do you mean by that?
Can you give an example of what had improved with ViewArgument and what is now gone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants