Rename "Properties" to "PropertySet"

[PoignardAzur]

Split properties.rs into (roughly) one file per struct/trait.

This is a moving-and-renaming-only PR, with no behavior changes.

[waywardmonkeys]

Given that this churns every open / pending change ... I'm not sure what the overall value / gain here is? Especially if we're talking about further substantial changes to properties... Help me understand?

[PoignardAzur]

The short version is that I have other changes in the pipeline that define other types like "PropertyStack" or "PropertyArena" and that a "Properties" type is ambiguous compared to them.

[waywardmonkeys]

The short version is that I have other changes in the pipeline that define other types like "PropertyStack" or "PropertyArena" and that a "Properties" type is ambiguous compared to them.

But feels a bit pre-mature because those changes wouldn't happen given some of the other stuff we want to talk about?

[PoignardAzur]

Right, I was skipping some context there. We're still discussing when and how we'll integrate features from understory_properties and your experimental branch using them.

I'd still like to merge this now. "Properties" is a bad name, and I'll still want to change it even (especially?) if we depend on understory_properties. I don't think this PR will make your work harder to integrate.

[xStrom]

Yes, this will create churn all over the place. However, the changes themselves aren't bad. So let's just merge this sooner rather than later and move on and spend time discussing more substantive things.