Open
Conversation
Starting with Rust 1.89, the __rust_probestack symbol from compiler-builtins is name-mangled and no longer exported, causing linker failures when building wasmer-vm on x86/x86_64. Conditionally vendor the probestack assembly from compiler-builtins when building with Rust >= 1.89, using rustversion for detection. On older Rust versions the behavior is unchanged. Cherry-picked from upstream wasmerio/wasmer@fc021be5c6f with a fix to use the old cargo: build script syntax for MSRV compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Twey
approved these changes
Mar 10, 2026
There was a problem hiding this comment.
Not sure I understand why this is in a build script that just renames the cfg. Could it not be inlined?
Author
|
This CI has been failing since the beginning (see the time when we released 4.4.X for linera #8) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Rust 1.89, the __rust_probestack symbol from compiler-builtins is name-mangled and no longer exported, causing linker failures when building wasmer-vm on x86/x86_64.
Conditionally vendor the probestack assembly from compiler-builtins when building with Rust >= 1.89, using rustversion for detection. On older Rust versions the behavior is unchanged.
Cherry-picked from upstream wasmerio/wasmer@fc021be5c6f with a fix to use the old cargo: build script syntax for MSRV compatibility.