Fix build: WherePath compat for both old and new type structures#63
Merged
Fix build: WherePath compat for both old and new type structures#63
Conversation
The WherePath type was refactored on main (WhereEvaluationPath/WhereAndOr replaced with WhereExpressionPath/WhereExistsPath). Update serialization to work with both variants: - Use `as unknown as` for structural casts that span both type structures - Add ExistsCondition serialization/deserialization (exists kind) - Dynamically resolve ExistsCondition constructor for cross-branch compat - Guard evaluation path with runtime `in` check instead of fallthrough https://claude.ai/code/session_01P6n2XLm5DSugoa8RWN97yy
Contributor
|
If this change doesn't need a release (docs, CI config, etc.), you can ignore this message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WherePathtype mismatch betweendev(old:WhereEvaluationPath | WhereAndOr | WhereExpressionPath) andmain(new:WhereExpressionPath | WhereExistsPath)as unknown asfor structural casts guarded by runtimeinchecksExistsConditionserialization/deserialization support (dynamically resolved so it compiles on both branches)Test plan
npm run buildsucceedstsconfig-cjs.jsonandtsconfig-esm.jsoncompile cleanhttps://claude.ai/code/session_01P6n2XLm5DSugoa8RWN97yy