Feat: hash plaintext email for SHA256_EMAIL identifier#16
Open
ZLeventer wants to merge 2 commits intolinkedin-developers:mainfrom
Open
Feat: hash plaintext email for SHA256_EMAIL identifier#16ZLeventer wants to merge 2 commits intolinkedin-developers:mainfrom
ZLeventer wants to merge 2 commits intolinkedin-developers:mainfrom
Conversation
…pers#14) Guard against undefined conversionValue before calling JSON.parse to prevent the tag from throwing when no conversion value is provided. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…in-developers#1) Refactor getUserEmail() to explicitly separate the three email source paths (UI override, pre-hashed sha256_email_address, and plaintext email_address) so the hashing flow via hashData()/sha256Sync is clear and plaintext emails from user_data.email_address are always SHA-256 hashed before being sent as the SHA256_EMAIL user identifier. Closes linkedin-developers#1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_data.email_addressis now properly routed throughhashData()/sha256Syncfor the SHA256_EMAIL identifiergetUserEmail()to clearly separate three email source paths:userIdsOverride.email) — returned directlyuser_data.sha256_email_address) — returned directlyeventModel.email,user_data.email_address,user_data.email) — returned for hashing byhashData()ingetUserIds()Test plan
user_data.email_addressand verify it gets SHA256-hashed in the CAPI payloaduser_data.sha256_email_addressand verify it passes through without double-hashing