Skip to content

Upgrade sarama to support Kafka 2.0.0 (#440) #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bai merged 1 commit into from
Oct 2, 2018
+3 −1
Merged

Upgrade sarama to support Kafka 2.0.0 (#440) #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gopkg.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[[constraint]]
name = "github.com/Shopify/sarama"
version = "1.17.0"
version = "1.18.0"

[[constraint]]
name = "go.uber.org/zap"
Expand Down
2 changes: 2 additions & 0 deletions core/internal/helpers/sarama.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ func parseKafkaVersion(kafkaVersion string) sarama.KafkaVersion {
return sarama.V1_0_0_0
case "1.1.0":
return sarama.V1_1_0_0
case "2.0.0":
return sarama.V2_0_0_0
default:
panic("Unknown Kafka Version: " + kafkaVersion)
}
Expand Down