Skip to content

Issue 730: inmemory deleteTopic is not thread-safe #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bai merged 1 commit into from
Apr 28, 2026
Merged

Issue 730: inmemory deleteTopic is not thread-safe #860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/internal/storage/inmemory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,13 +642,15 @@ func (module *InMemoryStorage) deleteTopic(request *protocol.StorageRequest, req
return
}

clusterMap.consumerLock.RLock()
// Work backwards - remove the topic from consumer groups first
for _, consumerMap := range clusterMap.consumer {
consumerMap.lock.Lock()
// No need to check for existence
delete(consumerMap.topics, request.Topic)
consumerMap.lock.Unlock()
}
clusterMap.consumerLock.RUnlock()

// Now remove the topic from the broker list
clusterMap.brokerLock.Lock()
Expand Down