Move transfer_tensors_to_device into utils/dist_utils#70
Open
sanjanag wants to merge 1 commit intolinkedin:masterfrom
Open
Move transfer_tensors_to_device into utils/dist_utils#70sanjanag wants to merge 1 commit intolinkedin:masterfrom
sanjanag wants to merge 1 commit intolinkedin:masterfrom
Conversation
The helper is generic dataclass-tensor plumbing that distributed setup code outside run_solver also needs. Lift it into utils/dist_utils so those callers don't have to import from run_solver, and keep run_solver using the same function via that import. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transfer_tensors_to_deviceis generic dataclass-tensor plumbing — movingit from
run_solverintoutils/dist_utilsmakes it reusable fromdistributed setup code (which builds per-rank input args before any
run_solvercall) without having to import fromrun_solver. Internalbehavior is unchanged;
run_solverkeeps using the same function via thatimport.
Test plan
pytest tests/ --ignore=tests/distributed)transfer_tensors_to_deviceimportable from bothdualip.utils.dist_utils(canonical) anddualip.run_solver(re-export)