Use Java Base64 instead of Apache Commons Base64 #3166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Java 8+, Java has a set of native Base64 utlities which are much more performant than the Apache Commons library. We observed some significant memory usage coming from the Base64 usaged in the codebase, and thus migrating to the Java native version will reduce memory allocation. In addition, this PR introduces a JMH benchmarking module which can be run via ./gradlew jmh. This module allows meaningful performance testing locally, allowing anyone to verify the performance gains asserted in a PR are actually true. We start out with a set of simple benchmarks showing the significant performance difference between the two Base64 implementations across various byte sizes. On my M4 MacBook Encode is about 30x faster and Decode 5x faster.
justinlin-linkedin
approved these changes
Nov 11, 2025
ambry-mysql/src/main/java/com/github/ambry/repair/MysqlRepairRequestsDb.java
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3166 +/- ##
============================================
+ Coverage 64.24% 69.85% +5.60%
- Complexity 10398 12786 +2388
============================================
Files 840 930 +90
Lines 71755 78926 +7171
Branches 8611 9427 +816
============================================
+ Hits 46099 55133 +9034
+ Misses 23004 20870 -2134
- Partials 2652 2923 +271 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
j-tyler
force-pushed
the
j-tyler/base64-with-jmh
branch
from
e4b48ba to
ba77e76
Compare
Apache 2 Base64 decode has special leniency for invalid encodings. To ensure full backwards compat we fall back to using Apache 2 when decoding fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Java 8+, Java has a set of native Base64 utlities which are much more performant than the Apache Commons library.
We observed some significant memory usage coming from the Base64 usaged in the codebase, and thus migrating to the Java native version will reduce memory allocation.
In addition, this PR introduces a JMH benchmarking module which can be run via ./gradlew jmh. This module allows meaningful performance testing locally, allowing anyone to verify the performance gains asserted in a PR are actually true. We start out with a set of simple benchmarks showing the significant performance difference between the two Base64 implementations across various byte sizes.
On my M4 MacBook Encode is about 30x faster and Decode 5x faster.
Testing Done
./gradlew buildpassed with no changes other than swapping in the new library.Benchmark results from my M4 MacBook on Friday Nov 7 2025. This is just a single sample
but the difference is in an order of magnitude.