Put Md5 with UT #3175
Merged
Put Md5 with UT #3175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SophieGuo410
left a comment
SophieGuo410
left a comment
There was a problem hiding this comment.
we need to make sure:
- the id converter in close source also gets update.
- we need to make sure all the db has this digest field before we merge this pr.
| deleted_ts datetime(6) DEFAULT NULL, | ||
| blob_size bigint unsigned DEFAULT 0, | ||
| modified_ts datetime(6) DEFAULT CURRENT_TIMESTAMP(6), | ||
| digest varchar(255) DEFAULT NULL, |
Contributor
There was a problem hiding this comment.
we don't need 255 length right? VARCHAR(50) is enough
| * Test put Named Blob with digest. | ||
| */ | ||
| @Test | ||
| public void putNamedBlobDigestTest() throws Exception { |
Contributor
There was a problem hiding this comment.
Can we also have some test in MySqlNamedBlobDbIntegrationTest to make sure the mysql query works fine.
| * @param version the version of this named blob. | ||
| * @param digest the digest of this blob | ||
| */ | ||
| public NamedBlobRecord(String accountName, String containerName, String blobName, String blobId, |
Contributor
There was a problem hiding this comment.
I feel like we have too many constructors which might not nessessary, we can try to combine them. we can have a follow up pr to do it.
SophieGuo410
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Put Md5 for caspian migration
Testing Done
unit test