Fix missing return statements #3189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two methods in InMemNamedBlobDb completed futures exceptionally but didn't return, allowing execution to continue and potentially complete the future again, causing index out of bounds (OOB) errors. I also added respective unit tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3189 +/- ##
============================================
+ Coverage 64.24% 69.90% +5.65%
- Complexity 10398 12812 +2414
============================================
Files 840 930 +90
Lines 71755 79009 +7254
Branches 8611 9434 +823
============================================
+ Hits 46099 55230 +9131
+ Misses 23004 20856 -2148
- Partials 2652 2923 +271 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
satishkotha
approved these changes
Dec 17, 2025
Comment on lines
+75
to
+76
| assertTrue("Future should be completed exceptionally", getFuture.isCompletedExceptionally()); | ||
| assertFalse("Future should not be completed normally", getFuture.isDone() && !getFuture.isCompletedExceptionally()); |
Contributor
There was a problem hiding this comment.
nit: 2nd assert is redundant. we could just keep one of these asserts.
justinlin-linkedin
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two methods in InMemNamedBlobDb completed futures exceptionally but didn't return, allowing execution to continue and potentially complete the future again, causing index out of bounds (OOB) errors.
Testing Done
I also added respective unit tests.