Add check for valid range on buffers #24
Conversation
Protects crashes on reading and writing of buffer if range is accessed beyond buffer size.
nikhilbedi
left a comment
nikhilbedi
left a comment
There was a problem hiding this comment.
Why is it going out of bounds in the first place?
| BOOL hasValidRange = buffer.length >= offset + 4; | ||
| if (hasValidRange) { | ||
| [buffer replaceBytesInRange:NSMakeRange(offset, 4) withBytes:&value]; |
There was a problem hiding this comment.
We need proper error handling if we're going to do this, otherwise consumers will not know why their data is not what they expect.
There was a problem hiding this comment.
we do not have enough information from JIRA to understand what core cause is on this.
I have changes locally for adding proper error handling mostly done, but it will alter most of the public API calls to have error properties, would we be ok with that change?
There was a problem hiding this comment.
We may not have information from JIRA, but we only have a few places where we adjust the buffer and its size.
In other words, the symptom is we are writing a value outside of the range of a buffer. The root issue is why are we providing a bad buffer in the first place?
I think there is an issue in our file expansion code.
re: error handling -- I think that's fine. It could pollute our internal code though, so we may just want to use try-catches internally.
Protects crashes on reading and writing
of buffer if range is accessed beyond
buffer size.