Skip to content

Keep min OFD TTL for replica table as 3 days if provided TTL is less than 3 days#414

Merged
jiang95-dev merged 3 commits intolinkedin:mainfrom
abhisheknath2011:ofd-ttl
May 1, 2026
Merged

Keep min OFD TTL for replica table as 3 days if provided TTL is less than 3 days#414
jiang95-dev merged 3 commits intolinkedin:mainfrom
abhisheknath2011:ofd-ttl

Conversation

@abhisheknath2011
Copy link
Copy Markdown
Member

@abhisheknath2011 abhisheknath2011 commented Dec 16, 2025

Summary

Issue] Briefly discuss the summary of the changes made in this
pull request in 2-3 lines.

We have decided to reduce OFD TTL internally within LI to min value to speed up the clean up of orphan files. However, would like to keep replica table TTL to 3 days so that replication process does not leave the replica table in corrupted state if replication is failing on a table for consecutive days. The 3 days TTL aligns with the current TTL set internally.

Changes

  • Client-facing API Changes
  • Internal API Changes
  • Bug Fixes
  • New Features
  • Performance Improvements
  • Code Style
  • Refactoring
  • Documentation
  • Tests

For all the boxes checked, please include additional details of the changes made in this pull request.

Testing Done

This would be verified internally.

  • Manually Tested on local docker setup. Please include commands ran, and their output.
  • Added new tests for the changes made.
  • Updated existing tests to reflect the changes made.
  • No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
  • Some other form of testing like staging or soak time in production. Please explain.

For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.

Additional Information

  • Breaking Changes
  • Deprecations
  • Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

@abhisheknath2011 abhisheknath2011 marked this pull request as ready for review December 16, 2025 23:26
Copy link
Copy Markdown
Collaborator

@jiang95-dev jiang95-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiang95-dev jiang95-dev merged commit d117d85 into linkedin:main May 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants