feat(optimizer): [1/N] Optimizer Repository#530
Open
mkuchenbecker wants to merge 4 commits intomkuchenb/optimizer-0from
Open
feat(optimizer): [1/N] Optimizer Repository#530mkuchenbecker wants to merge 4 commits intomkuchenb/optimizer-0from
mkuchenbecker wants to merge 4 commits intomkuchenb/optimizer-0from
Conversation
Spring Data JPA repositories for all four optimizer tables with filtered query support. Includes tests exercising save/find, filtered queries, upsert semantics, and append-only history. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
17 tasks
17 tasks
mkuchenbecker
commented
Apr 6, 2026
mkuchenbecker
commented
Apr 6, 2026
mkuchenbecker
commented
Apr 6, 2026
mkuchenbecker
commented
Apr 6, 2026
mkuchenbecker
commented
Apr 6, 2026
Address PR review comments: rename findFiltered → find across all repos, remove redundant findByTableUuid/findByTableUuidSince from history repos, add explicit assertion to context test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Shared JPA entities and repositories for optimizer apps (analyzer, scheduler). All repos expose a single find method with optional filters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Propagate CompleteOperationRequest orphan field removal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mkuchenbecker
changed the title
mkuchenbecker
changed the title
mkuchenbecker
changed the title
This was referenced Apr 7, 2026
| @Column(name = "id", nullable = false, length = 36) | ||
| private String id; | ||
|
|
||
| @Column(name = "table_uuid", nullable = false, length = 36) |
Member
There was a problem hiding this comment.
It would be good to capture databaseId and tableId for getting historical insights on table operations.
Collaborator
Author
There was a problem hiding this comment.
Claude: Added databaseName and tableName columns (both VARCHAR(128)) to TableOperationHistoryRow in commit 027fccd6. The underlying schema already carries them, so this is purely an entity-level addition that lets analyst-style queries read the history without joining back to table_operations.
|
|
||
| dependencies { | ||
| implementation 'org.springframework.boot:spring-boot-starter-data-jpa:2.7.8' | ||
| implementation 'com.vladmihalcea:hibernate-types-55:2.21.1' |
Member
There was a problem hiding this comment.
Where exactly this dependency is used? Seems like new dependency.
Collaborator
Author
There was a problem hiding this comment.
Claude: It is used by TableStatsRow in this shared module. The @TypeDef(name = "json", typeClass = JsonStringType.class) and @Type(type = "json") annotations on TableStatsRow.stats and TableStatsRow.tableProperties resolve to com.vladmihalcea.hibernate.type.json.JsonStringType, which lives in this dependency. It is the same library already used by services/optimizer for the same purpose.
mkuchenbecker
added a commit
to mkuchenbecker/openhouse
that referenced
this pull request
May 1, 2026
…y row Address PR linkedin#530 review feedback: the lightweight read-side TableOperationHistoryRow in the apps/optimizer shared module did not surface the denormalized database_name and table_name columns, even though the underlying schema carries them. Add them so analyst-style queries from the analyzer/scheduler side can read operation history without joining back to table_operations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizer Stack
Summary
PR 1 of N in the optimizer stack.
Overall Project
Service Design doc.
Spring Data JPA repositories for all four optimizer tables with filtered query support, plus tests exercising save/find, filtered queries, upsert semantics, and append-only history.
Changes
Repositories:
TableOperationsRepository,TableOperationsHistoryRepository,TableStatsRepository,TableStatsHistoryRepository— each with JPQL filtered query methods.Tests: Repository tests for all four tables plus
OptimizerServiceContextTestverifying the Spring context loads.Testing Done
./gradlew :services:optimizer:test— all tests pass (H2 in MySQL mode).Additional Information