Skip to content

Escape changed file names in code-path notification emails#7

Open
theinfosecguy wants to merge 2 commits intolinkedin:masterfrom
theinfosecguy:theinfosecguy/escape-codepath-email-content
Open

Escape changed file names in code-path notification emails#7
theinfosecguy wants to merge 2 commits intolinkedin:masterfrom
theinfosecguy:theinfosecguy/escape-codepath-email-content

Conversation

@theinfosecguy
Copy link
Copy Markdown

@theinfosecguy theinfosecguy commented Mar 27, 2026

Summary

  • Escape changed file names before inserting them into HTML email content in send-notification-on-change.js.
  • Escape other interpolated values in the generated email body and stop logging raw HTML payloads.
  • Add explicit pull-requests: read permission in code-path-changes.yml for least-privilege API access clarity.
  • Skip notification execution when mail OAuth secrets are not configured so the workflow exits cleanly instead of failing all PRs.

Testing Done

  • Reviewed escaping paths for all interpolated HTML fields.
  • Verified secret-missing path exits successfully in script and workflow gating.
  • CI run validation in upstream repository by maintainers.

Copy link
Copy Markdown
Member

@ChrisCarini ChrisCarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Consider contributing this upstream, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants