Fixing setup.py to include dex2jar correctly #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to use `pip install .` to install qark recently in a vagrant machine and encountered the following error: ``` can't copy 'qark/lib/dex2jar-2.0/lib': doesn't exist or not a regular file ``` I am not 100% familiar with setup.py but fixxing this line to `*.*` so pip would try to copy only files with extension in dex2jar directory works. `*` would instruct pip to also copy lib child folder which cause the error above. San
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
I tried to use
pip install .to install qark recently in a vagrant machine and encountered the following error:I am not 100% familiar with setup.py but fixing this line to
*.*to instruct pip to only copy files with extensions in dex2jar directory works.*would cause pip to attempt to copy the child folderlibwhich throw the error above.San