Make xds directory lazy to subscribe names #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycezhongqing
approved these changes
Jan 31, 2025
PapaCharlie
approved these changes
Jan 31, 2025
dg-builder
pushed a commit
to dg-builder/rest.li
that referenced
this pull request
Sep 2, 2025
* make xds directory lazy to subscribe names * optimize test to get watcher with count down latch * make watcher private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't want all apps to subscribe to d2 cluster / service names at startup, which could be a bit waste. This change makes the subscription lazy to happen at when first real request comes in. INDIS Server response is very fast, so it should be ok to subscribe lazily.
Test Done
UT.