Dark Cluster Partition Support #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @Override | ||
| public int getClusterCountAcrossPartitions(String clusterName, String scheme) throws ServiceUnavailableException |
Contributor
There was a problem hiding this comment.
It seems to me that all partitions should be handled independently. As in, this method should return Map<Integer, Integer>. The overall host count might not be a good indicator of the traffic multipliers. The same server host can register with multiple partitions at the service owners' discretion. It's possible that some partitions have 10x the number of hosts in the dark cluster while others have only 1x.
…st.li into jleezer/dc-partition-support
darkcluster/src/main/java/com/linkedin/darkcluster/impl/DarkClusterManagerImpl.java
Outdated
Show resolved
Hide resolved
darkcluster/src/main/java/com/linkedin/darkcluster/impl/DarkClusterStrategyFactoryImpl.java
Outdated
Show resolved
Hide resolved
shivamgupta1
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for routing dark cluster traffic to partitioned hosts. For the most part the logic needed for this was present and working however the ClusterInfoProvider class was only using the Default Partition (0) to calculate the different host sizes. This has two problems, first the rate wont match what the user sets. And more importantly, if the cluster has no hosts that announce to 0, then the calculated QPS rate will be 0 and no traffic will be sent.
Testing
This issue was first reported with a cluster that did not announce to the default partition for both source and dark cluster. With the changes here, dark cluster traffic was routed to their dark host announced to partition 10.