null guards for xds server and channel #1110
Merged
+33
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohhyang
requested review from
PapaCharlie,
ZoabKapoor,
abhics1002 and
brycezhongqing
|
|
||
| public D2ClientBuilder setXdsServer(String xdsServer) | ||
| { | ||
| checkNotNull(xdsServer, "xdsServer"); |
Collaborator
There was a problem hiding this comment.
We don't need this right ? See my other comment we could directly to throw Exception there.
Contributor
Author
There was a problem hiding this comment.
this is called earlier than when createChannel is called. This can throw as soon as anyone is setting null, instead of wait until XdsChannelFactory actually try to use the null.
Collaborator
There was a problem hiding this comment.
IIRC, without the nullable annotation, the parameter should already be treated as non-null.
Contributor
Author
There was a problem hiding this comment.
For coding wise, yes, but it won't prevent any user from actually calling it with a null. That's what happened to some espresso-pub users. So we need this explicit null check and throw.
brycezhongqing
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title, add null guards for critical params. Also add a setter to disable detecting raw d2 client, so test apps like indis-canary can use it to disable the detection as needed.
Test Done
N/A