Skip to content

Conversation

@bohhyang
Copy link
Contributor

Summary

  1. Change throw to log for duplicate xds client start. The start() method can be called multiple times for valid reasons, since app owners are allowed to explicitly call d2Client.start and wait for the callback to ensure a d2 client is started before using it. We should change the throw to an info log and just return (no-op) in that case.
  2. Only in indis-only read, we should throw when setting xds server address to null. Currently the check is mis-applied to zk read too, zk read is still used in DEV testings with local zk.

@bohhyang bohhyang merged commit e1802cd into master Oct 15, 2025
2 checks passed
@bohhyang bohhyang deleted the by/throwToLog branch October 15, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants