Rate limit dark cluster exceptoin logging #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| catch (RuntimeException | PartitionAccessException | ServiceUnavailableException e) | ||
| { | ||
| _log.error("Cannot find partition id for request: {}, defaulting to 0", request.getURI(), e); | ||
| _rateLimitedLogger.error("Cannot find partition id for request: {}, defaulting to 0", request.getURI(), e); |
Contributor
There was a problem hiding this comment.
It's possible that if there are many logs of one of these two types, only one of them will be ever seen. To avoid this, two rate limited logger instances need to be created.
Contributor
Author
There was a problem hiding this comment.
Updated to use two loggers.
added 3 commits
October 15, 2025 12:42
…nto jleezer/rate-limit-dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions can lead to a large amount of logs so use a rate limited logger.