Skip to content

Conversation

@bohhyang
Copy link
Contributor

Summary

Fixes a few issues in xds client metrics so that:

  1. when initial data has not been received (for wildcard subscriber, could be haven't received the last batch), reconnections won't reset subscribe time and the subscriber state (still in INIT_PENDING), so that the wait time and server latency metrics can be tracked with the initial subscribe time.
  2. when IRV enabled, after reconnect, receiving no new update since existing data is up-to-date, the active wait time metric is 0.
  3. when IRV is disabled, receiving the same data after reconnection will set the subscribers to FETCHED state (from PENDING_AFTER_RECONNECT), so the wait time metric is 0.

Testing Done

QEI deploy indis-canary, verified under both IRV enabled and disabled cases, the logs and metrics are as expected.

Copy link
Contributor

@ZoabKapoor ZoabKapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks right to me and the added tests are very thorough, thanks for fixing this!

It looks like you'll need to re-sync master and bump the version again before merging though

@bohhyang bohhyang force-pushed the by/subscribeWaitTime branch from 679348e to 6bad4c7 Compare November 4, 2025 17:45
@bohhyang bohhyang merged commit 922f8b3 into master Nov 4, 2025
3 of 4 checks passed
@bohhyang bohhyang deleted the by/subscribeWaitTime branch November 4, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants