Indis based d2 warmup for restli client #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamgupta1
commented
Oct 29, 2025
| /** | ||
| * Records the callee service information and periodically sends out the recorded information to a persistence medium. | ||
| */ | ||
| public interface D2CalleeInfoRecorder { |
Contributor
Author
There was a problem hiding this comment.
This interface should've been added here and re-used in grpc infra. However, now I'll add an adapter internally to re-use that one for its implementation.
TylerHorth
approved these changes
Oct 31, 2025
| // the call fails, we still *intend* to use serviceName, so it should be in _usedServices. | ||
| String serviceName = LoadBalancerUtil.getServiceNameFromUri(request.getURI()); | ||
| _usedServices.add(serviceName); | ||
| if (_d2CalleeInfoRecorder != null && D2_SCHEME_NAME.equalsIgnoreCase(request.getURI().getScheme())) |
Contributor
There was a problem hiding this comment.
I'm curious, what is the reason for checking the scheme?
Contributor
Author
There was a problem hiding this comment.
I'm not sure if this decorator LB is only ever used for d2:// requests. Currently, the recording of warmup service names doesn't happen here. Those are fetched from the d2 data stored on disk, which happens asynchronously via the property buses. I just wanna be sure that we don't record any unneeded information here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds fetching of downstream services to warmup using Indis. Builds on #1123.
Testing done
Deployed locally.