Cleanup unused code added to not delete existing screenshots #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This PR cleans up the now unused code added under PR#80. - Removed method `ShakeDelegate#enableDeletingOldScreenshots()` used to determine enabling/disabling deletion of old screenshots. - Also deleted related code usages.
li-advait
approved these changes
Aug 7, 2025
li-advait
reviewed
Sep 4, 2025
| * Please note that, when disabled, it is the responsibility of the integrating app to delete | ||
| * the old screenshots as and when required. | ||
| */ | ||
| public boolean enableDeletingOldScreenshots() { |
Contributor
There was a problem hiding this comment.
since we are deleting a public api, lets bump to next major version
Contributor
Author
There was a problem hiding this comment.
We've made changes per your suggestion.
PTAL!
li-advait
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ShakeDelegate#enableDeletingOldScreenshots()used to determine enabling/disabling deletion of old screenshots.Testing Done