Skip to content

Few more fixes #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
li-advait wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Few more fixes #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
444e6f7
Few more fixes
li-advait Aug 4, 2025
3271a3c
Few more fixes
li-advait Aug 4, 2025
8563994
Merge branch 'main' into amahasha/few_more_fixes
li-advait Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shaky-sample/src/main/java/com/linkedin/android/shaky/app/ShakyDemo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ protected void onCreate(Bundle savedInstanceState) {

// Initialize ScreenCaptureManager for the Shaky library
((ShakyApplication) getApplication()).getShaky().initializeScreenCapture(this);

ViewCompat.setOnApplyWindowInsetsListener(
getWindow().findViewById(R.id.demo_background),
(v, insets) -> {
Expand Down
14 changes: 8 additions & 6 deletions shaky/src/main/java/com/linkedin/android/shaky/ScreenCaptureManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@
import android.view.Display;
import android.view.WindowManager;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.activity.result.ActivityResult;
import androidx.activity.result.ActivityResultLauncher;
import androidx.activity.result.contract.ActivityResultContracts;
import androidx.fragment.app.FragmentActivity;

import androidx.activity.result.ActivityResult;
import androidx.activity.result.ActivityResultLauncher;
Expand Down Expand Up @@ -81,6 +83,10 @@ public void requestCapturePermission(Activity activity, CaptureCallback callback
throw new IllegalStateException("ScreenCaptureManager must be initialized before requesting permission. Call initialize() in onCreate().");
}

if (mediaProjectionLauncher == null) {
throw new IllegalStateException("ScreenCaptureManager must be initialized before requesting permission. Call initialize() in onCreate().");
}

this.captureCallback = callback;

// Get screen metrics
Expand All @@ -105,10 +111,6 @@ public void requestCapturePermission(Activity activity, CaptureCallback callback
*/
private void handleActivityResult(ActivityResult result) {
if (result.getResultCode() == Activity.RESULT_OK && result.getData() != null) {
return false;
}

if (resultCode == Activity.RESULT_OK && data != null) {
// Start the foreground service before creating MediaProjection
ScreenCaptureService.start(appContext);

Expand Down
Loading