Skip to content

Conversation

@li-pbhadour
Copy link
Contributor

@li-pbhadour li-pbhadour commented Sep 9, 2025

Summary

  • This PR adds support to launch Edit Screenshot flow manually using the existing support in Shaky library.

Support

  • Added support of type enum to differentiate between different FlowType.
  • Updated FeedbackType#newIntent with new parameter for flow type and further store it in intent extras to distinguish between feedback and edit screenshot flow.
  • Added a new constant key ActionConstants#ACTION_START_SCREENSHOT_EDIT_FLOW to trigger the screenshot edit flow manually.
  • Added support to launch startDrawFragment for both Bug Report and Edit Screenshot actions when screenshot is available in FeedbackActivity#onCreate.
  • Updated FeedbackActivity#changeToFragment to prevent adding the fragment transaction for edit screenshot flow thus ensuring editor closes once the flow completes, instead of returning to an empty screen.
  • Added support FeedbackActivity#submitEditScreenshotIntent to send broadcast using intent action ACTION_COMPLETE_EDIT_SCREENSHOT of the edited screenshot URI and updated the BroadcastReceiver to receive the intent for edit screenshot flow type.
  • Added support Shake#startEditScreenshotFlow to start the flow based on whether a screenshot is available, otherwise starts the standard feedback flow.
  • Added support ShakeDelegate#submitScreenshot to provide a callback for handling the edited screenshot result after the flow completes.
  • Added support to retrieve the screenshot Uri from the intent received on BroadcastReceiver in FeedbackActivity#createReceiver and to notify that flow is completed.
  • Added a demo button in layout activity_demo.xml and invoked the edit screenshot flow on its tapped action in ShakyDemo#onCreate.

Testing Done

  • Tested locally. Please refer the attached recordings.
  • Feedback Flow is launched when the screenshot is not available (null).
  • Edit Screenshot Flow is launched when screenshot is available.
Scenario Feedback Flow Edit Screenshot Flow (tested through debug changes)
Video
FeedbackFlow.mp4
EditScreenshotFlow.mp4

- This PR adds support to launch edit screenshot flow using `Shaky#startEditScreenshotFlow()` if the param `screenshotUri` is not null.
@li-advait li-advait merged commit 0692dfa into linkedin:main Sep 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants