Add support to perform custom action on hearing shake #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2025 17:05
- Added boolean property enableCustomHandlingOfShake to enable/disable custom handling of shake event. - If property is false, handle shaky initialisation flow at shaky-android side else at listeners side.
li-advait
reviewed
Nov 11, 2025
| * This method can be overridden to provide custom action to be performed on shake when | ||
| * {@link #enableCustomHandlingOfShake} is enabled. | ||
| */ | ||
| public void performCustomActionOnShake(@NonNull Activity activity){} |
Contributor
There was a problem hiding this comment.
are you adding sample implementation for this in sample app?
Author
There was a problem hiding this comment.
Sure, we can add it once done with the current priority tasks.
Please let us know if we should prioritise this instead.
li-advait
reviewed
Nov 11, 2025
shaky/src/main/java/com/linkedin/android/shaky/ShakeDelegate.java
Outdated
Show resolved
Hide resolved
li-advait
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to perform custom action on hearing shake
custom handling of shake event.
performCustomActionOnShakewhich can be overridden to providecustom action to be performed on detecting shake.
hearShakemethod to perform the provided custom action, if customhandling is enabled.
Testing Done
Tested locally and verified that no existing functionality is affected.
noExistingFunctionalityAffected.mp4