This repository was archived by the owner on Dec 6, 2024. It is now read-only.
Rewrite linkerd-tcp #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkerd-tcp 0.1.0 constitues a major rewrite. Previously, linkerd-tcp did not properly utilize tokio's task model, which lead to a number of performance and correctness problems. Furthermore, linkerd-tcp's configuration interface was substantially different from linkerd's, which caused some confusion. Now, linkerd-tcp has been redesigned: - to better-leverage tokio's reactor; - to support connection and stream timeouts; - to provide much richer metrics insight; - to be structured like a linkerd-style router; - general correctness improvements. Fixes #26 #40 #49 #50 Depends on linkerd/tacho#20
enable per-client max_waiters and min_connections settings - Don't do connection backoffs. They weren't thought out well. - Don't use consecutive failures to assess load. - Add fail fast. - Remove balancer::Updater, because the dispatcher task needs to be notified on resolutions. - Make Ctx RAII again don't do overcomplicated probabalistic p2c. just simple lowest-score-wins handle failures properly when updating from service discovery
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linkerd-tcp 0.1.0 constitues a major rewrite.
Previously, linkerd-tcp did not properly utilize tokio's task model, which lead
to a number of performance and correctness problems. Furthermore, linkerd-tcp's
configuration interface was substantially different from linkerd's, which
caused some confusion.
Now, linkerd-tcp has been redesigned:
Fixes #26 #40 #49 #50
Depends on linkerd/tacho#20