Move ffts_aligned_malloc() and ffts_aligned_free() to the public API#12
Open
emmenlau wants to merge 1 commit intolinkotec:masterfrom
Open
Move ffts_aligned_malloc() and ffts_aligned_free() to the public API#12emmenlau wants to merge 1 commit intolinkotec:masterfrom
emmenlau wants to merge 1 commit intolinkotec:masterfrom
Conversation
Author
|
This should be a mostly harmless change, that brings ffts more in line with typical behavior of fftw and other fft libraries. Also it simplifies writing tests for ffts. Let me know what you think? |
Author
|
Anyone? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests currently like to use
_mm_malloc()orvalloc()for aligned allocation intests/test.c. Better and cleaner seems to be the use offfts_aligned_malloc()andffts_aligned_free(). And this may be also what downstream users want to use? Its at least in line with other FFT libraries.This PR makes the methods public.