feat: omnibox live server search + cross-platform build fix#142
Open
ehorizon7 wants to merge 1 commit intolinkwarden:mainfrom
Open
feat: omnibox live server search + cross-platform build fix#142ehorizon7 wants to merge 1 commit intolinkwarden:mainfrom
ehorizon7 wants to merge 1 commit intolinkwarden:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Omnibox: live server search
The omnibox previously only searched a local cache, which is empty on fresh installs
and only grows as links are saved through the extension. This meant new users got no
suggestions until they'd built up a cache.
This adds a live call to
/api/v1/searchon each omnibox input (2+ characters),merging server results with cached results (deduped by URL). If the server is
unreachable it silently falls back to the local cache, preserving existing behavior.
Cross-platform build script
Replaced the Unix-only
cpcommand in the build script with a Node.jsfs.copyFileSynccall sonpm run buildworks correctly on Windows withouta manual copy step.