Fix CSP to allow data: URIs for image upload#143
Open
M3shour wants to merge 1 commit intolinkwarden:mainfrom
Open
Fix CSP to allow data: URIs for image upload#143M3shour wants to merge 1 commit intolinkwarden:mainfrom
M3shour wants to merge 1 commit intolinkwarden:mainfrom
Conversation
The "Upload image from browser" feature converts images to base64 data URIs, but the Content-Security-Policy connect-src directive blocks data: scheme fetches, causing a NetworkError. Adding data: to connect-src resolves this.
|
confirmed fix, works on Firefox/Zen Browser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data:URIs, then fetches them to create a blob for uploadconnect-srcdirective ('self' http: https:) blocksdata:scheme fetches, causing aNetworkError when attempting to fetch resourcedata:toconnect-srcresolves thisCloses linkwarden/linkwarden#1613
Related linkwarden/linkwarden#1629
Fix
One-line change in
manifest.json: adddata:to theconnect-srcCSP directive.