Skip to content

fix(job): remove default value for useORCS in job.yaml #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 12, 2025
Merged

fix(job): remove default value for useORCS in job.yaml #2513

merged 5 commits into from
Sep 12, 2025

Conversation

CasLubbers
Copy link
Contributor

📌 Summary

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

ElderMatt
ElderMatt requested changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it also be changed in post-job.yaml?

@CasLubbers
Copy link
Contributor Author

Should it also be changed in post-job.yaml?

Good point, its removed

j-zimnowoda
j-zimnowoda reviewed Sep 12, 2025
View reviewed changes
@CasLubbers CasLubbers merged commit 23b15f8 into main Sep 12, 2025
11 checks passed
@CasLubbers CasLubbers deleted the fix-no-orcs branch September 12, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merll merll merll approved these changes

@j-zimnowoda j-zimnowoda j-zimnowoda approved these changes

@ElderMatt ElderMatt ElderMatt approved these changes

@Ani1357 Ani1357 Awaiting requested review from Ani1357 Ani1357 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CasLubbers @merll @j-zimnowoda @ElderMatt @svcAPLBot